Support esp-idf v6.0#334
Draft
Narukara wants to merge 1 commit into
Draft
Conversation
c34c11b to
5641bd9
Compare
5641bd9 to
acda650
Compare
Contributor
|
This pull request is in conflict. Could you fix it @Narukara? |
acda650 to
07b3f3f
Compare
ecd3823 to
e811475
Compare
e811475 to
7f6db2c
Compare
Lapshin
reviewed
Jun 29, 2026
|
|
||
| add_compile_definitions(ESP_PLATFORM LWIP_IPV4 LWIP_IPV6 PLATFORM_NAME_FREERTOS) | ||
| # Keep `__STDC_WANT_LIB_EXT1__=1` until micro-ROS/rcutils includes ros2/rcutils#555. | ||
| add_compile_definitions(ESP_PLATFORM LWIP_IPV4 LWIP_IPV6 PLATFORM_NAME_FREERTOS __STDC_WANT_LIB_EXT1__=1) |
There was a problem hiding this comment.
Note that __STDC_WANT_LIB_EXT1__ is implemented only for picolibc
|
Not related to this MR: Declaring this project as an IDF component while also having an With this approach, you can lose the required compile options and break the ABI when linking the final ELF. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #325, #324, #323, #329
WIP