Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashNow() zero hops by default #9

Open
wants to merge 3 commits into
base: 1.2.x
Choose a base branch
from

Conversation

timdev
Copy link
Contributor

@timdev timdev commented Apr 1, 2021

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Description

This PR builds on #8 in a way that does not preserve BC.

I've changed the signature for flashNow() by changing the default value for the $hops argument from one to zero.

This means that messages set with flashNow() are now visible only in the current request by default. Users who want such messages to persist beyond the current request can pass a positive integer top $hops.

@timdev timdev force-pushed the topic/flashnow-zero-hops-default branch from 43ae815 to 22aafb1 Compare April 15, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flashNow() messages persist beyond the current request
2 participants