Allow zero hops for flashNow() #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. Ref: mezzio#7 Signed-off-by: Tim Lieberman <[email protected]>
This was referenced Apr 1, 2021
Signed-off-by: Tim Lieberman <[email protected]>
|
@froschdesign |
… 0 $hops Signed-off-by: Tim Lieberman <[email protected]>
|
@timdev |
Signed-off-by: Tim Lieberman <[email protected]>
timdev
force-pushed
the
topic/7-flashnow-allow-zero-hops
branch
from
b980da7
to
3513492
Compare
|
D'oh. Fixed now. |
froschdesign
approved these changes
Apr 14, 2021
|
@timdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See discussion on #7.
This PR allows passing zero as the third argument to flashNow(), enabling users
to set a message that is visible only on the current request.