Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdownlint issues #15

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Mar 26, 2024

This commit:

  • Aligns the .md files with the markdownlint requirements.

This commit:
- Aligns the .md files with the markdownlint requirements.

Signed-off-by: Adam Rozman <[email protected]>
@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Mar 26, 2024

/hold
First need to merge #14 to unblock the Functional test

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@Rozzii Rozzii requested a review from dtantsur March 26, 2024 07:58
@Rozzii
Copy link
Member Author

Rozzii commented Mar 28, 2024

/remove hold

@Rozzii Rozzii removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should be holding it to be merged only after Prow PR is merged, so we can see it passes.

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Mar 28, 2024

/retest

@Rozzii
Copy link
Member Author

Rozzii commented Mar 28, 2024

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Mar 28, 2024

/cc @elfosardo

@metal3-io-bot metal3-io-bot requested a review from elfosardo March 28, 2024 13:27
@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rozzii!

LGTM

@dtantsur
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@metal3-io-bot metal3-io-bot merged commit 4b98139 into metal3-io:main Mar 28, 2024
7 checks passed
@tuminoid tuminoid mentioned this pull request Mar 28, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants