Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 update OpenSSF CII Best Practices badge #883

Merged
merged 1 commit into from
Feb 4, 2025
Merged

📖 update OpenSSF CII Best Practices badge #883

merged 1 commit into from
Feb 4, 2025

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #868

/assign tuminoid

@tuminoid
update OpenSSF CII Best Practices badge
37eddc0 
OpenSSF CII Best Practices badge is expected to be repository specific.
Our old badge is organization-wide, and does not quality for points
in OpenSSF Scorecard for example.

I've done the CII analysis for IPAM alone, and we have received a
passing badge for IPAM now.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot mentioned this pull request Feb 4, 2025
Merged
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.8 milestone Feb 4, 2025
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2025
tuminoid
tuminoid reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle 📖 update OpenSSF CII Best Practices badge
/approve
/lgtm

@metal3-io-bot metal3-io-bot changed the title [release-1.8] 📖 update OpenSSF CII Best Practices badge 📖 update OpenSSF CII Best Practices badge Feb 4, 2025
@metal3-io-bot metal3-io-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2025
@tuminoid
Copy link
Member

tuminoid commented Feb 4, 2025

/override metal3-ubuntu-e2e-integration-test-release-1-8
It'll merge when CI is back up.

@metal3-io-bot
Copy link
Contributor Author

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-release-1-8

In response to this:

/override metal3-ubuntu-e2e-integration-test-release-1-8
It'll merge when CI is back up.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sunnatillo
Sunnatillo reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid
Copy link
Member

tuminoid commented Feb 4, 2025

/retest

@metal3-io-bot metal3-io-bot merged commit cca5365 into metal3-io:release-1.8 Feb 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@mquhuy mquhuy Awaiting requested review from mquhuy

Assignees

@tuminoid tuminoid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
IPAM - v1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@metal3-io-bot @tuminoid @Sunnatillo