Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove IPAM deployment logic #1993

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚠️ Remove IPAM deployment logic #1993

wants to merge 1 commit into from

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Sep 19, 2024 •
edited
Loading

When making IPAm into a provider for CAPI, I needed to change the namespace where IPAM is living and how IPAM is deployed. This PR is made to match those changes in IPAM. There are also changes to metal-dev-env. These are the related PRs:

All three PRs' changes need to be tested together. Check test in the metal-dev-env PR.

What this PR does / why we need it: To be compatible with IPAM changes

@peppi-lotta peppi-lotta marked this pull request as draft September 19, 2024 11:53
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign smoshiur1237 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2024
@tuminoid
Copy link
Member

Should this be marked a breaking change as it is switching namespaces and hence upgrades are affected?

@peppi-lotta peppi-lotta changed the title 🌱Change namespace for IPAM to fit changes ⚠️ Change namespace for IPAM to fit changes Sep 23, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/change-IPAM-namespace branch from 47d85ca to 993dda2 Compare September 30, 2024 11:01
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2024
@peppi-lotta peppi-lotta mentioned this pull request Oct 2, 2024
Open
@peppi-lotta
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Contributor

@peppi-lotta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main 993dda2 link true /test metal3-ubuntu-e2e-integration-test-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@peppi-lotta peppi-lotta marked this pull request as ready for review November 7, 2024 12:19
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024
@peppi-lotta peppi-lotta mentioned this pull request Nov 7, 2024
Open
@peppi-lotta peppi-lotta changed the title ⚠️ Change namespace for IPAM to fit changes ⚠️ Remove IPAM deployment logic Nov 8, 2024
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2024
@tuminoid
Copy link
Member

/hold
This needs to go in to 1.10 cycle, so holding until 1.9 is cut.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
@peppi-lotta peppi-lotta mentioned this pull request Nov 20, 2024
Closed
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/change-IPAM-namespace branch from 993dda2 to a105ee7 Compare December 2, 2024 12:40
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2024
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 19, 2024
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peppi-lotta @metal3-io-bot @tuminoid