Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Decoupling IPAM from CAPM3 #1442

Closed
wants to merge 1 commit into from
Closed

⚠️ Decoupling IPAM from CAPM3 #1442

wants to merge 1 commit into from

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Feb 6, 2024 •
edited
Loading

These changes fix the issues produced by this PR in CAPM3

@peppi-lotta
Decoupling IPAM from CAPM3
eae0935 
Signed-off-by: peppi-lotta <[email protected]>
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboukhalfa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2024
@Rozzii
Copy link
Member

Rozzii commented Feb 15, 2024

/cc @lentzi90 @zaneb @kashifest @schrej

tuminoid
tuminoid reviewed Feb 15, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits.

BTW, the link in PR summary links to a check in a PR, not to PR itself.

config/default/kustomization.yaml
- capm3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line feed missing.

config/ipam/image_patch.yaml
@@ -2,7 +2,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: ipam-controller-manager
namespace: capm3-system
namespace: ipam-provider-m3-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is one weird name. Is there reasoning behind that? I expected to see simple ipam-system or similar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Suggested ipam-metal3-system in the IPAM PR

@peppi-lotta peppi-lotta mentioned this pull request May 7, 2024
Closed
@peppi-lotta peppi-lotta marked this pull request as draft May 7, 2024 12:48
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2024
@metal3-io-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rozzii Rozzii added this to the 1.8.0 milestone Jun 28, 2024
@peppi-lotta
Copy link
Member Author

#1993
This PR is doing the same thing as this. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

@lentzi90 lentzi90 Awaiting requested review from lentzi90

@schrej schrej Awaiting requested review from schrej

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
CAPM3 - v1.9
Development

Successfully merging this pull request may close these issues.
6 participants
@peppi-lotta @metal3-io-bot @Rozzii @tuminoid @lentzi90 @adilGhaffarDev