Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Fix enableBMHNameBasedPreallocation label to ENABLE_BMH_NAME_BASED_PR… #1751

Merged
merged 1 commit into from
Jul 8, 2024
Merged

⚠️ Fix enableBMHNameBasedPreallocation label to ENABLE_BMH_NAME_BASED_PR… #1751

merged 1 commit into from
Jul 8, 2024

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Jun 10, 2024 •
edited by adilGhaffarDev
Loading

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1242

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2024
@peppi-lotta peppi-lotta changed the title Fix enableBMHNameBasedPreallocation label to ENABLE_BMH_NAME_BASED_PR… 🐛 Fix enableBMHNameBasedPreallocation label to ENABLE_BMH_NAME_BASED_PR… Jun 10, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-main

smoshiur1237
smoshiur1237 reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@kashifest
Copy link
Member

/hold
For the change requested and feature test to pass

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 11, 2024
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-enableBMHNameBasedPreallocation-label branch from 203389d to c6b8310 Compare June 11, 2024 11:32
@peppi-lotta
Copy link
Member Author

/test metal3-ubuntu-e2e-feature-test-main
/test metal3-centos-e2e-feature-test-main

@kashifest
Copy link
Member

/test metal3-ubuntu-e2e-feature-test-main

@kashifest
Copy link
Member

/test metal3-centos-e2e-feature-test-main

1 similar comment
@kashifest
Copy link
Member

/test metal3-centos-e2e-feature-test-main

@kashifest
Copy link
Member

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

@kashifest kashifest changed the title 🐛 Fix enableBMHNameBasedPreallocation label to ENABLE_BMH_NAME_BASED_PR… ⚠️ Fix enableBMHNameBasedPreallocation label to ENABLE_BMH_NAME_BASED_PR… Jun 24, 2024
Sunnatillo
Sunnatillo reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
@tuminoid
Copy link
Member

/hold For the change requested and feature test to pass

All tests are passed, shall we unhold?

@Rozzii Rozzii added this to the 1.8.0 milestone Jun 28, 2024
@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2024
@Rozzii
Copy link
Member

Rozzii commented Jul 8, 2024

I will check what docs will need to change to support this then we can merge.

@Rozzii
Copy link
Member

Rozzii commented Jul 8, 2024

@adilGhaffarDev has volunteered to create an updated version of this PR and we will try to get this merged.

@adilGhaffarDev adilGhaffarDev force-pushed the peppi-lotta/fix-enableBMHNameBasedPreallocation-label branch from c6b8310 to fdd6e7b Compare July 8, 2024 08:29
@metal3-io-bot metal3-io-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 8, 2024
@adilGhaffarDev
Copy link
Member

I have rebased it, please check.

@adilGhaffarDev
Copy link
Member

LGTM from my side @mboukhalfa @Rozzii please check

@adilGhaffarDev
Copy link
Member

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

Rozzii
Rozzii reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@Rozzii
Copy link
Member

Rozzii commented Jul 8, 2024

/hold cancel
let's see what breaks :D

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2024
@metal3-io-bot metal3-io-bot merged commit 906e598 into metal3-io:main Jul 8, 2024
16 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/fix-enableBMHNameBasedPreallocation-label branch July 8, 2024 12:57
@adilGhaffarDev adilGhaffarDev mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@Sunnatillo Sunnatillo Sunnatillo left review comments

@Rozzii Rozzii Rozzii left review comments

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Metal3 - Roadmap
Status: Done / Closed
Milestone
CAPM3 - v1.8
Development

Successfully merging this pull request may close these issues.

Fix environment variable format for enableBMHNameBasedPreallocation
8 participants
@peppi-lotta @metal3-io-bot @kashifest @tuminoid @Rozzii @adilGhaffarDev @Sunnatillo @smoshiur1237