-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix environment variable format for enableBMHNameBasedPreallocation #1242
Comments
/triage accepted |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
This is something that we would like to implement but currently no-one is working on this so I am moving it to frozen. |
@Rozzii: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What steps did you take and what happened:
We currently use the variable
enableBMHNameBasedPreallocation
here.Unfortunately, clusterctl does not pick up variables using this format (lower case), as explained here. We should change the variable to the proper format.
Unfortunately, this means a change for users. And users may already be using this variable from the
clusterctl.yaml
config file (where is works correctly in the current format). I'm not sure what to think about this. Does it require a minor version bump?Edit: I think we have to change the variable, but the flag can stay the same. It would be best to do this in a minor release since it would be a breaking change for users setting the variable in
clusterctl.yaml
.What did you expect to happen:
The variable should be picked up by clusterctl when generating
infrastructure-components.yaml
. See kubernetes-sigs/cluster-api#8097 for more details./kind bug
The text was updated successfully, but these errors were encountered: