Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Decoupling IPAM from CAPM3 #1442

Closed
wants to merge 1 commit into from
Closed

⚠️ Decoupling IPAM from CAPM3 #1442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions config/default/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ commonLabels:
cluster.x-k8s.io/provider: "infrastructure-metal3"

resources:
- capm3
- ../ipam
- capm3
2 changes: 1 addition & 1 deletion config/ipam/image_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: ipam-controller-manager
namespace: capm3-system
namespace: ipam-provider-m3-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is one weird name. Is there reasoning behind that? I expected to see simple ipam-system or similar

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Suggested ipam-metal3-system in the IPAM PR

spec:
template:
spec:
Expand Down
2 changes: 1 addition & 1 deletion config/ipam/pull_policy_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: ipam-controller-manager
namespace: capm3-system
namespace: ipam-provider-m3-system
spec:
template:
spec:
Expand Down
Loading