Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update node version to v20 for release and testing workflow #738

Merged
merged 8 commits into from
Mar 12, 2024

Conversation

mesaugat
Copy link
Contributor

@mesaugat mesaugat commented Mar 4, 2024

Updates

  • Update release workflow as it is failing because new version of semantic-release requires node v20 or above
  • Update testing workflow to use node v20
  • Use recent version of GitHub actions for actions/checkout and actions/setup-node
  • Bump probot to version ^13.0.2 as some tests were failing (especially smoke and scheduler test) in the previous version
  • Bump jest and nock to latest versions --> nock was not mocking http requests in a few cases, don't know the exact reason but upgrading the version did work 🤷
  • Cleanup nock stuff after scheduler test is done

@mesaugat mesaugat changed the title fix: update node version to v20 fix: update node version to v20 for release and testing workflow Mar 4, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (375def2) to head (0897130).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #738   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files         110      110           
  Lines        2878     2878           
  Branches      578      578           
=======================================
  Hits         2674     2674           
  Misses        185      185           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shine2lay shine2lay merged commit a675dcf into mergeability:master Mar 12, 2024
4 checks passed
Copy link

🎉 This PR is included in version 2.17.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

ftmiro added a commit to ftmiro/mergeable that referenced this pull request May 15, 2024
Node 20 is required to run mergeable after mergeability#738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants