Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergeable app cannot be enforced after upgrade to node v20 #739

Open
horia-stoenescu opened this issue Mar 12, 2024 · 6 comments
Open

Mergeable app cannot be enforced after upgrade to node v20 #739

horia-stoenescu opened this issue Mar 12, 2024 · 6 comments

Comments

@horia-stoenescu
Copy link

Hello,

After doing this upgrade for node version to v20: #738, mergeable app stopped working as it could not read anymore configuration from .github/mergeable.yml.

Also, I cannot see this github app in my status checks for branch protection rules: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks#checks anymore 😞 .

Is there anyone else who saw this kind of issue after the upgrade?

Thank,
Horia

@davidalbers
Copy link

I'm having issues after the upgrade as well, I can still see the app in the status checks but it never reports success or failure.

@horia-stoenescu
Copy link
Author

I'm having issues after the upgrade as well, I can still see the app in the status checks but it never reports success or failure.

Yes, same for me. And after removing it from status checks, I could not add it back.

@horia-stoenescu
Copy link
Author

horia-stoenescu commented Mar 12, 2024

What I've managed to do as a workaround for now:

@shine2lay
Copy link
Member

I'll try to revert it back to last known working build

@horia-stoenescu
Copy link
Author

I'll try to revert it back to last known working build

It seems now that it's solved, thanks a lot 😁 . New commits in PRs are able to trigger this check for Mergeable.
Also, it can be enabled as required in branch protection rules.

Is there a planned hotfix for this upgrade to node v20?
I am asking in order to make sure that no such issues will appear in the near future.

Thank you,
Horia

@andekande
Copy link
Contributor

Ho exactly did you upgrade?
The referenced PR just bumbed node version in the ci-cd pipeline because some tools required that.
That's different from the runtime the bot is hosted with. In Dockerfile its still on 18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants