Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9547): add password change feature on first time login #9581
base: master
Are you sure you want to change the base?
feat(#9547): add password change feature on first time login #9581
Changes from 11 commits
d7173a6
523fc30
1ef9996
efe3a72
057782c
63017ca
bfa9485
c9b570d
f1dea9a
7e15098
d2d18e9
9d1c055
8fee9e8
0323df5
935c721
f4f4de0
04b3f97
1a4e971
f6d9949
d693b75
01acf08
a4ea9a6
13092d1
ecc3f82
20cde88
74ed3e2
fcf73bd
b3ec3f0
c15cced
3c0f2fa
5fcb64d
1f223f8
5a24839
ff6192c
4817bb1
47d990b
0a814c6
2bc1603
3e6fd03
dd73991
b48c967
f649876
8511c67
cbde20f
71ccda5
cf77f9f
6c7d976
e0806e0
95d5f9c
40bee0a
87170ff
c23d3e2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
try
block can be in the service instead, so the controller is responsible of prepare the response to the front-end. What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which service do you have in mind ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
login service or auth service. Which one do you think fit better?