-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#9547): add password change feature on first time login #9581
Open
Benmuiruri
wants to merge
52
commits into
master
Choose a base branch
from
9547-change-password
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
d7173a6
chore: test password change routing
Benmuiruri 523fc30
Add password reset flag to API
Benmuiruri 1ef9996
chore: add password validation
Benmuiruri efe3a72
chore: add password validation error msgs
Benmuiruri 057782c
chore: prevent unauthorized access before password change
Benmuiruri 63017ca
chore: redirect back to login if not password reset
Benmuiruri bfa9485
chore: use cookie to prevent access
Benmuiruri c9b570d
chore: try cookie to show UI
Benmuiruri f1dea9a
chore: show password success UI
Benmuiruri 7e15098
sonar reduce cognitive
Benmuiruri d2d18e9
chore: sonar fixes
Benmuiruri 9d1c055
Merge branch 'master' of github.com:medic/cht-core into 9547-change-p…
Benmuiruri 8fee9e8
chore: interpolate translations
Benmuiruri 0323df5
chore: first round of feedback
Benmuiruri 935c721
chore: additional feedback
Benmuiruri f4f4de0
chore: refactor password validation
Benmuiruri 04b3f97
chore: refactor toggle password and legacy code
Benmuiruri 1a4e971
chore: remove passwordUpdate cookie and set minimal cookie without Auth
Benmuiruri f6d9949
chore: refactor setting basic Cookie
Benmuiruri d693b75
chore: clean password reset
Benmuiruri 01acf08
chore: fix userService unit test
Benmuiruri a4ea9a6
chore: add fr translations
Benmuiruri 13092d1
Merge branch 'master' of github.com:medic/cht-core into 9547-change-p…
Benmuiruri ecc3f82
chore: refactor to initial flow
Benmuiruri 20cde88
chore: simplify check
Benmuiruri 74ed3e2
chore: add ne translations
Benmuiruri fcf73bd
chore: use getUserDoc not getUserCtx
Benmuiruri b3ec3f0
chore: refactor password reset, add password reset unit test
Benmuiruri c15cced
chore: refactor password validation
Benmuiruri 3c0f2fa
chore: set password_change_required on password update
Benmuiruri 5fcb64d
chore: update e2e to do password reset
Benmuiruri 1f223f8
Add password reset e2e
Benmuiruri 5a24839
disable eslint to run tests in ci
Benmuiruri ff6192c
try api eslint
Benmuiruri 4817bb1
chore: add unit tests
Benmuiruri 47d990b
chore: skip password reset for admin
Benmuiruri 0a814c6
chore: self review
Benmuiruri 2bc1603
chore: update service worker unit test
Benmuiruri 3e6fd03
chore: update integration tests and fix login e2e
Benmuiruri dd73991
chore: sonar
Benmuiruri b48c967
Merge branch 'master' of github.com:medic/cht-core into 9547-change-p…
Benmuiruri f649876
chore: add selector specificity
Benmuiruri 8511c67
address feedback
Benmuiruri cbde20f
validate user changing password
Benmuiruri 71ccda5
chore: try iife pattern
Benmuiruri cf77f9f
chore: sonar
Benmuiruri 6c7d976
validate password reset in auth middleware
Benmuiruri e0806e0
update e2e
Benmuiruri 95d5f9c
Merge branch 'master' of github.com:medic/cht-core into 9547-change-p…
Benmuiruri 40bee0a
chore: update breaking e2e
Benmuiruri 87170ff
chore: sonar
Benmuiruri c23d3e2
chore: update e2e tests
Benmuiruri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really bad idea because it's complicating production code to make testing work. Furthermore this will block ever testing the following paths.