Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update syntax for Anchor Positioning related properties #770

Merged
merged 2 commits into from
Oct 23, 2024
Merged

feat: update syntax for Anchor Positioning related properties #770

merged 2 commits into from
Oct 23, 2024

Conversation

skyclouds2001
Copy link
Contributor

Description

https://drafts.csswg.org/css-anchor-position-1/#anchor-size-fn for anchor-size()
https://drafts.csswg.org/css-anchor-position-1/#position-anchor for position-anchor

Motivation

Additional details

Related issues and pull requests

KEEFER82

This comment was marked as spam.

Sign in to view

@skyclouds2001 skyclouds2001 marked this pull request as ready for review October 9, 2024 03:37
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner October 9, 2024 03:37
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team October 9, 2024 03:37
@skyclouds2001 skyclouds2001 changed the title Update syntax for Anchor Positioning Update syntax for Anchor Positioning related properties Oct 9, 2024
@skyclouds2001 skyclouds2001 changed the title Update syntax for Anchor Positioning related properties feat: update syntax for Anchor Positioning related properties Oct 12, 2024
pepelsbey
pepelsbey reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from a little detail: the element reference is called <anchor-name> in the spec but we call it <anchor-element>. Is there a reason for that? They might’ve renamed it recently, too.

@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Oct 18, 2024 •
edited
Loading

it seems to be so when the data is added via #728 by @chrisdavidmills ,and at that time it is <anchor-element>

it has changed to <anchor-name> which happens at w3c/csswg-drafts@1d18c6a recently, this seems to be a simple rename and replace

so I've updated according to the spec

also /cc @chrisdavidmills

pepelsbey
pepelsbey approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you :)

@chrisdavidmills chrisdavidmills mentioned this pull request Oct 21, 2024
Merged
@chrisdavidmills
Copy link
Contributor

Thanks a lot for this, @skyclouds2001. I've created a PR at mdn/content#36424 to make the equivalent updates in the content repo.

@chrisdavidmills
Copy link
Contributor

@pepelsbey, can you merge this one? I don't have the necessary privs, unfortunately.

@pepelsbey pepelsbey merged commit 5f5c637 into mdn:main Oct 23, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Merged
@skyclouds2001 skyclouds2001 deleted the anchor-positioning branch October 23, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KEEFER82 KEEFER82 KEEFER82 left review comments

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skyclouds2001 @chrisdavidmills @pepelsbey @KEEFER82