Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change anchor-element parameters to anchor-name, as per spec change #36424

Merged

Conversation

chrisdavidmills
Copy link
Contributor

Description

In the CSS anchor positioning spec, the anchor() and anchor-size() functions' <anchor-element> parameters have been changed to <anchor-name> (see w3c/csswg-drafts@1d18c6a).

This makes sense, as those parameters are anchor-name values.

This PR makes the necessary updates to the MDN docs.

See also mdn/data#770. It looks like the position-anchor syntax changes were already accounted for in the docs, so this PR just has to worry about the anchor() and anchor-size() changes.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner October 21, 2024 10:03
@chrisdavidmills chrisdavidmills requested review from bsmth and removed request for a team October 21, 2024 10:03
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Oct 21, 2024
Copy link
Contributor

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, Chris!

@chrisdavidmills chrisdavidmills merged commit fe427ad into mdn:main Oct 21, 2024
7 checks passed
@chrisdavidmills chrisdavidmills deleted the anchor-element-to-anchor-name branch October 21, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants