Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing spec_url for svg <stop> element #25131

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add missing spec_url for svg <stop> element #25131

merged 1 commit into from
Nov 20, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 19, 2024 •
edited
Loading

Summary

Test results and supporting details

Related issues

Part of the #24162
Relates to #25130
Relates to mdn/data#782

@github-actions github-actions bot added the data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG label Nov 19, 2024
@skyclouds2001 skyclouds2001 mentioned this pull request Nov 19, 2024
Merged
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 19, 2024 23:15
@skyclouds2001 skyclouds2001 mentioned this pull request Nov 19, 2024
Merged
caugner
caugner reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thought regarding the manually added mdn_url.

svg/elements/stop.json Show resolved Hide resolved
@caugner caugner merged commit b34a060 into mdn:main Nov 20, 2024
5 checks passed
@skyclouds2001 skyclouds2001 deleted the svg-stop branch November 20, 2024 10:48
@skyclouds2001 skyclouds2001 mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyclouds2001 @caugner