Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove svg.global_attributes.stop-color #25130

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 19, 2024

Summary

stop-color is not a global attribute, it can only use on SVG <stop> elements

current data in https://github.com/mdn/browser-compat-data/blob/main/svg/elements/stop.json#L91-L133 has already covered this feature and is more detailed

Test results and supporting details

https://svgwg.org/svg2-draft/pservers.html#StopColorProperty
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stop-color

Related issues

Relates to #25131
Relates to mdn/data#782

@github-actions github-actions bot added the data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG label Nov 19, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 19, 2024 23:15
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is consistent with stop-opacity.

@caugner caugner merged commit 6a7b9ea into mdn:main Nov 20, 2024
5 checks passed
@mdn-bot mdn-bot mentioned this pull request Nov 20, 2024
@skyclouds2001 skyclouds2001 deleted the svg.global_attributes.stop-color branch November 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:svg Compat data for SVG features. https://developer.mozilla.org/docs/Web/SVG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants