Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Dockerfile to allow containerized running of powerpwn #87

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Create Dockerfile to allow containerized running of powerpwn #87

merged 2 commits into from
Dec 17, 2024

Conversation

shanko07
Copy link
Collaborator

@shanko07 shanko07 commented Dec 5, 2024

Re-did these changes on top of the latest version of main, removed the need for insecure --no-sandbox by running as a standard user in the container.

AvishaiEZen
AvishaiEZen approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@AvishaiEZen AvishaiEZen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Sanity test looks good.
  2. I did have an issue with the localhost port, however, might be a specific misconfiguration for me, not sure. Let's discuss offline.

Approving to unblock for now.

@AvishaiEZen AvishaiEZen merged commit dbf2da8 into mbrg:main Dec 17, 2024
6 checks passed
@AvishaiEZen AvishaiEZen mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvishaiEZen AvishaiEZen AvishaiEZen approved these changes

Assignees

@mbrg mbrg

@AvishaiEZen AvishaiEZen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanko07 @AvishaiEZen @mbrg