Skip to content

Conversation

EdJoPaTo
Copy link
Contributor

@EdJoPaTo EdJoPaTo commented Jun 13, 2023

WmLanguageCode is too specific for Wikibase and only relevant on Wikidata.

This is a breaking change as WmLanguageCode and languages are gone.

closes #111

@maxlath
Copy link
Owner

maxlath commented Jul 31, 2023

I'm fine with export type LanguageCode = string but would like to keep export const wikimediaLanguageCodes, as it is arguably still useful for some projects working with Wikibase, even if mostly when working with Wikidata (I primarily have in mind inventaire, which is the project that motivated this lib in the first place ;)). Those languages being accessible in scripts/update_wikimedia_constants.ts#L32, it should be straightforward to re-include them(?)

@maxlath
Copy link
Owner

maxlath commented Jul 31, 2023

@EdJoPaTo For the needs of the review, I locally rebased on main and solved the conflicts, I can push that rebased+resolved branch here if you like.

EdJoPaTo added 4 commits July 31, 2023 23:19
WmLanguage code is too specific for Wikibase and
only relevant on Wikidata
They are not relevant for Wikibase but helpful in depending
projects like Inventaire.
@EdJoPaTo EdJoPaTo force-pushed the language-code branch 2 times, most recently from 7588628 to ca9d7e2 Compare July 31, 2023 21:40
Ensure backwards compatibility
@EdJoPaTo
Copy link
Contributor Author

As wikimediaLanguageCodes is back now and WmLanguageCode has a deprecated export this shouldn't be a breaking change anymore if I am correct and haven't overlooked something.

@maxlath maxlath merged commit 0d8b0eb into maxlath:main Aug 1, 2023
@EdJoPaTo EdJoPaTo deleted the language-code branch August 1, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants