Load Languages from Wikidata #111
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently WmLanguageCode is based on the sites. I updated the scripts to load both the sites and the languages from Wikidata. As Wikidata probably knows all the languages from other Wikimedia projects it seems like a good source of languages for me.
I also changed some code related to languages and removed the
shortLang
method. The shortLang reduced the options usable for methods like getEntities as you couldn’t specifyde-ch
earlier as it was automatically reduced tode
. This seems like a bug to me but I might miss something?All the test cases still work except one which I think was a bug:
getSitelinkData().lang
included _ which only sites include. The language like it’s used in URLs and the lang arguments uses the -. The getSitelinkUrl also depends on it so I think this was another bug and the test case was also wrong.Fixes #107
Uses a helper from #106 so it should be merged first. Only the last commit is unique to this PR.