Fix false positives on Comodo Dragon browser for Dragon-model devices. #7552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
While looking at detection of some Chrome-based browsers, I noticed that some Android devices with the word "Dragon" in their model name (Figgers DragonX, Dragon OTT, and HyperX Dragon) were being detected as the Comodo Dragon browser. Comodo Dragon seems to be a desktop-only browser according to their website, so I believe these detections are incorrect.
This bug seems to have been originally introduced in #6019, which loosened the regex from
Comodo[ _]Dragon(?:/(\d+[\.\d]+))?
to(?:Comodo[ _])?Dragon(?!fruit)(?:/(\d+[\.\d]+))?
(making the "Comodo" part optional as long as it isn't in the context of the word "Dragonfruit"). However, that PR didn't add any new test cases for the Comodo Dragon browser to indicate that the browser uses a user agent without the word "Comodo".Review