Skip to content

Commit a41bf18

Browse files
authored
Fix detect Dragon browser (#7552)
* Fix false positives on Comodo Dragon browser for Dragon-model devices. * Add and handle test case with just Dragon/.
1 parent 52346ab commit a41bf18

File tree

5 files changed

+22
-13
lines changed

5 files changed

+22
-13
lines changed

Tests/Parser/Client/fixtures/browser.yml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7851,3 +7851,12 @@
78517851
engine: Blink
78527852
engine_version: ""
78537853
family: Chrome
7854+
-
7855+
user_agent: Mozilla/5.0 (Windows NT 10.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36 Dragon/103.0.2674.92
7856+
client:
7857+
type: browser
7858+
name: Comodo Dragon
7859+
version: "103.0.2674.92"
7860+
engine: Blink
7861+
engine_version: "104.0.0.0"
7862+
family: Chrome

Tests/fixtures/smartphone-33.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2113,10 +2113,10 @@
21132113
platform: ""
21142114
client:
21152115
type: browser
2116-
name: Comodo Dragon
2117-
version: ""
2118-
engine: WebKit
2119-
engine_version: "537.36"
2116+
name: Chrome Mobile
2117+
version: "105.0.0.0"
2118+
engine: Blink
2119+
engine_version: "105.0.0.0"
21202120
device:
21212121
type: smartphone
21222122
brand: Figgers

Tests/fixtures/smartphone-35.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8345,10 +8345,10 @@
83458345
platform: ""
83468346
client:
83478347
type: browser
8348-
name: Comodo Dragon
8349-
version: ""
8350-
engine: WebKit
8351-
engine_version: "537.36"
8348+
name: Chrome Mobile
8349+
version: "78.0.3904.96"
8350+
engine: Blink
8351+
engine_version: "78.0.3904.96"
83528352
device:
83538353
type: smartphone
83548354
brand: SKK Mobile

Tests/fixtures/tv-1.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8712,10 +8712,10 @@
87128712
platform: ""
87138713
client:
87148714
type: browser
8715-
name: Comodo Dragon
8716-
version: ""
8717-
engine: WebKit
8718-
engine_version: "537.36"
8715+
name: Chrome Webview
8716+
version: "103.0.5060.129"
8717+
engine: Blink
8718+
engine_version: "103.0.5060.129"
87198719
device:
87208720
type: tv
87218721
brand: DRAGON

regexes/client/browsers.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1719,7 +1719,7 @@
17191719
default: '' # multi engine
17201720

17211721
#Comodo Dragon
1722-
- regex: '(?:Comodo[ _])?Dragon(?!fruit)(?:/(\d+[\.\d]+))?'
1722+
- regex: '(?:Comodo[ _])?Dragon/(\d+[\.\d]+)'
17231723
name: 'Comodo Dragon'
17241724
version: '$1'
17251725
engine:

0 commit comments

Comments
 (0)