Skip to content

Initialize pool manager with timeout #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hynekdav wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

Initialize pool manager with timeout #977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions massive/rest/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ def __init__(
backoff_factor=0.1, # [0.0s, 0.2s, 0.4s, 0.8s, 1.6s, ...]
)

# https://urllib3.readthedocs.io/en/stable/reference/urllib3.util.html#urllib3.util.Timeout
timeout = urllib3.Timeout(connect=connect_timeout, read=read_timeout)

# https://urllib3.readthedocs.io/en/stable/reference/urllib3.poolmanager.html
# https://urllib3.readthedocs.io/en/stable/reference/urllib3.connectionpool.html#urllib3.HTTPConnectionPool
self.client = urllib3.PoolManager(
Expand All @@ -76,10 +79,9 @@ def __init__(
ca_certs=certifi.where(),
cert_reqs="CERT_REQUIRED",
retries=retry_strategy, # use the customized Retry instance
timeout=timeout, # set timeout for each request
)

self.timeout = urllib3.Timeout(connect=connect_timeout, read=read_timeout)

if verbose:
logger.setLevel(logging.DEBUG)
self.trace = trace
Expand Down
Loading