Initialize pool manager with timeout #977
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes HTTP timeout handling in
BaseClient.The client was initializing
connect_timeoutandread_timeout, but the timeout was not applied to requests.This change ensures the configured timeout is actually used by the underlying
urllib3client.Motivation
Without an enforced timeout, HTTP requests can block for an unbounded amount of time, which can lead to:
Since the client already exposes timeout parameters, this aligns the behavior with what users would reasonably expect.
What changed
self.timeoutinitialization before creating thePoolManager.PoolManagerwith the configured timeout so it is applied to requests.Impact
Notes
urllib3usage.