Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that the EC2 instance is not terminated if unit tests failed #1103

Merged
merged 12 commits into from
Jan 27, 2025
Merged

Fix a bug that the EC2 instance is not terminated if unit tests failed #1103

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4b313f2
Test if test fails
wanliAlex Jan 24, 2025
675554b
Test if test fails
wanliAlex Jan 24, 2025
66dba1b
Test if test fails
wanliAlex Jan 24, 2025
8eac00e
Test if test fails
wanliAlex Jan 24, 2025
cee16ba
Test if test fails
wanliAlex Jan 24, 2025
d0816f0
Test if test fails
wanliAlex Jan 24, 2025
bbfda4c
Test if test fails
wanliAlex Jan 24, 2025
102f77a
Test if test fails
wanliAlex Jan 24, 2025
8256def
Test if test fails
wanliAlex Jan 24, 2025
87ad85e
Test if test fails
wanliAlex Jan 24, 2025
a75e400
Final
wanliAlex Jan 24, 2025
b7fa9b4
Final
wanliAlex Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/unit_test_200gb_CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,11 +279,12 @@ jobs:
Stop-Runner:
name: Stop self-hosted EC2 runner
needs:
- Check-Changes # required to start the main job when the runner is ready
- Start-Runner # required to get output from the start-runner job
- Test-Marqo # required to wait when the main job is done
- Check-Changes
runs-on: ubuntu-latest
if: ${{ needs.start-runner.outputs.label }} # Only stop the runner if it was started
if: |
always() && needs.Start-Runner.result == 'success'
steps:
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
Expand Down
Loading