Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug that the EC2 instance is not terminated if unit tests failed #1103

Merged
merged 12 commits into from
Jan 27, 2025

Conversation

wanliAlex
Copy link
Collaborator

@wanliAlex wanliAlex commented Jan 24, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    The EC2 instance is not terminated if unit tests failed

  • What is the new behavior (if this is a feature change)?
    I have verified that:

  1. If a unit tests run is needed and it failed, the ec2 instance will be terminated;
  2. If a unit tests run is not needed, no ec2 instance will be started and the termination job won't run.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@wanliAlex wanliAlex changed the title Test if test fails Fix a bug that the EC2 instance is not terminated if unit tests failed Jan 24, 2025
@wanliAlex wanliAlex merged commit 68652f4 into mainline Jan 27, 2025
10 checks passed
@wanliAlex wanliAlex deleted the li/fix-failed-test branch January 27, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants