Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[accessibility] Remove role="list" from Attribution #12857

Merged
merged 3 commits into from
Sep 12, 2023
Merged

[accessibility] Remove role="list" from Attribution #12857

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4d6ac8
Remove role list from attribution inner container
kumilange Aug 18, 2023
ac5f254
Remove role listitem from sourceCache attribution
kumilange Aug 18, 2023
c5e1778
Revert "Remove role listitem from sourceCache attribution"
kumilange Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/ui/control/attribution_control.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ class AttributionControl {
this._compactButton.addEventListener('click', this._toggleAttribution);
this._setElementTitle(this._compactButton, 'ToggleAttribution');
this._innerContainer = DOM.create('div', 'mapboxgl-ctrl-attrib-inner', this._container);
this._innerContainer.setAttribute('role', 'list');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumiko-haraguchi could we just include this change in your PR and revert those other changes? I can make the upstream changes to remove listitem without having to intercept them in the dom.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tristen Thank you, I just reverted the commit! 73706e6


if (compact) {
this._container.classList.add('mapboxgl-compact');
Expand Down
Loading