[accessibility] Remove role="list" from Attribution #12857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristen
requested changes
Aug 19, 2023
| @@ -64,7 +64,6 @@ class AttributionControl { | |||
| this._compactButton.addEventListener('click', this._toggleAttribution); | |||
| this._setElementTitle(this._compactButton, 'ToggleAttribution'); | |||
| this._innerContainer = DOM.create('div', 'mapboxgl-ctrl-attrib-inner', this._container); | |||
| this._innerContainer.setAttribute('role', 'list'); | |||
There was a problem hiding this comment.
@kumiko-haraguchi could we just include this change in your PR and revert those other changes? I can make the upstream changes to remove listitem without having to intercept them in the dom.
tristen
approved these changes
Aug 28, 2023
tristen
changed the title
stepankuzmin
force-pushed
the
rm-rolelist-attribution
branch
from
73706e6
to
c5e1778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling the good first issue #11033, removing
role="list"androle="listitem"from Attribution.[Before]
[After]
Note about removing role="listitem"
Attribution link elements seem to be provided from TileJSON and this original source should be fixed.
I don't seem to have access to fix it so I removed it from the attribution source obtained bythis._map.style._sourceCachesin this PR as a quick fix.I hope someone in the Mapbox team could handle this part.
role="listitem"from TileJSONLaunch Checklist
mapbox-gl-jschangelog:<changelog>Remove role="list" and role="listitem" from Attribution</changelog>