Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have added the space animation #69

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

manognyaa
Copy link

Description

issue number : 11
I have added the space animation using css and html. Since, the theme is rolling on space. I thought of adding a space rocket which will make the background to be more beautiful. Adding to it, the background will be moving like you can imagine a take off rocket in the space in jet speed. Isn't it amazing ??

  • Bugs : NA
  • New Feature : I have added a take off rocket and the rocket will move l
  • Documentation : changed in readme contributor session file added .

How Has This Been Tested?

I did this project in Visual Studio Code and ran in the website. It was working well.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

here am attaching gif of my work @manankohlii sir.

space-bg_gif

@netlify
Copy link

netlify bot commented Jun 11, 2021

✔️ Deploy Preview for launchspacex ready!

🔨 Explore the source changes: 2425feb

🔍 Inspect the deploy log: https://app.netlify.com/sites/launchspacex/deploys/60d74113752a890007fc41dd

😎 Browse the preview: https://deploy-preview-69--launchspacex.netlify.app

@manankohlii
Copy link
Owner

@manognyaa you have just pushed the code for your animation. This should be comparable with the current code in the master branch. Try to add this animation as background for launchspacex.netlify.app

@manognyaa
Copy link
Author

@manognyaa you have just pushed the code for your animation. This should be comparable with the current code in the master branch. Try to add this animation as background for launchspacex.netlify.app

okay sir, I will add the animation to the website. @manankohlii

@manognyaa
Copy link
Author

hello @manankohlii sir ,
I have updated the main HTML file please verify it and if any changes are required please guide.
Thank you.

@manankohlii
Copy link
Owner

Good job @manognyaa ! Although I believe the current background looks better right now. But I will keep you updated because we can definitely use this animation for another section of the website in the future!

@manankohlii manankohlii mentioned this pull request Jun 23, 2021
@manankohlii
Copy link
Owner

@manognyaa hello. Your animation was used as a pre loader for the website! Can you make changes to this PR so that I can merge it and you can get the credit? Just change a word or letter in the README and I'll merge it. If you have any issues msg me on Discord.

@manognyaa
Copy link
Author

hello sir, I have resolved the conflicts. please guide me if any changes required @manankohlii sir.

@manankohlii
Copy link
Owner

@akashchouhan16 has been reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants