Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre loader added #116

Merged
merged 4 commits into from
Jun 23, 2021
Merged

pre loader added #116

merged 4 commits into from
Jun 23, 2021

Conversation

marizvi
Copy link
Contributor

@marizvi marizvi commented Jun 23, 2021

Hi,
This is with reference to issue number #78 ,
I have resolved the following issue by adding pre-loader animation which will display loading animation while the loading of site in the process..
If everything is fine according to you then kindly merge my part of code.
And if anything else needed then kindly let me know anytime..

@netlify
Copy link

netlify bot commented Jun 23, 2021

✔️ Deploy Preview for launchspacex ready!

🔨 Explore the source changes: 094d3ee

🔍 Inspect the deploy log: https://app.netlify.com/sites/launchspacex/deploys/60d2e320026fda0008ec7926

😎 Browse the preview: https://deploy-preview-116--launchspacex.netlify.app

@manankohlii
Copy link
Owner

@marizvi hey this animation does not seem relevant to the website. Can you try adding the animation in PR #69 instead?

@marizvi
Copy link
Contributor Author

marizvi commented Jun 23, 2021

Changes done,
Kindly look for it now..

@manankohlii
Copy link
Owner

@marizvi animation looks good but you need to make it responsive. On mobile view scroll down when loading or have a look at the ss attached. The animation should be the only thing visible on load.
Screenshot (28)

@marizvi
Copy link
Contributor Author

marizvi commented Jun 23, 2021

Sorry for the inconvenience,
Done with the necessary changes.
Kindly have a look on it again please.

@manankohlii manankohlii added LGMSOC21 This issue will be considered for LGM-SOC 21 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 30 labels Jun 23, 2021
@manankohlii manankohlii merged commit 610d4f8 into manankohlii:master Jun 23, 2021
@manankohlii
Copy link
Owner

@marizvi no worries. Looks good now, merging! Thank you for your contribution 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 30 LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants