-
Notifications
You must be signed in to change notification settings - Fork 1
Restore native packaging project and fix CI solution path #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
KSemenenko
wants to merge
2
commits into
main
from
codex/fix-msbuild-project-specification-error-5h26ws
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <Solution> | ||
| <Configurations> | ||
| <Platform Name="Any CPU" /> | ||
| <Platform Name="x64" /> | ||
| <Platform Name="x86" /> | ||
| </Configurations> | ||
KSemenenko marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <Folder Name="/src/"> | ||
| <Project Path="src/MLXSharp.Native/MLXSharp.Native.csproj" /> | ||
| <Project Path="src/MLXSharp.SemanticKernel/MLXSharp.SemanticKernel.csproj" /> | ||
| <Project Path="src/MLXSharp.Tests/MLXSharp.Tests.csproj" /> | ||
| <Project Path="src/MLXSharp/MLXSharp.csproj" /> | ||
| </Folder> | ||
| </Solution> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # MLXSharp.Native | ||
|
|
||
| This package mirrors the layout that MLXSharp expects when resolving native binaries. | ||
| It ships the `libmlxsharp` stub that our managed layer uses during development and in automated tests. | ||
| The Linux stub lives as a Base64-encoded payload (`libmlxsharp.so.b64`) so we can keep Git history free of binary blobs. | ||
| `MlxNativeLibrary` expands the encoded payload to `libmlxsharp.so` automatically the first time the native backend loads. | ||
| Drop the macOS build of the wrapper into `runtimes/osx-arm64/native/` before publishing a release build. | ||
| This helper project mirrors the runtime layout that MLXSharp expects when probing for native binaries. | ||
| It ships the stubbed `libmlxsharp` artefacts that our managed layer exercises during development and CI runs. | ||
| The Linux build lives as a Base64-encoded payload (`libmlxsharp.so.b64`) so Git history stays free of large binary blobs. | ||
| `MlxNativeLibrary` expands that payload to `libmlxsharp.so` on demand, while macOS builds should drop the compiled | ||
| `libmlxsharp.dylib` into `runtimes/osx-arm64/native/` before packing a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| Place the macOS arm64 build of libmlxsharp.dylib here before packing MLXSharp.Native for distribution. | ||
| Place the macOS arm64 build of libmlxsharp.dylib here before packing MLXSharp for distribution. | ||
KSemenenko marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.