Skip to content

Conversation

@KSemenenko
Copy link
Member

Summary

  • restore the MLXSharp.Native packaging project and wire it back into MLXSharp so runtimes ship from a dedicated project
  • update the .slnx solution and CI workflow to use the new solution format while keeping native assets copied into MLXSharp.Native
  • refresh documentation to point to the reinstated native runtime paths

Testing

  • not run (dotnet CLI unavailable in container)

https://chatgpt.com/codex/tasks/task_e_68e229d761248326b7098a2b8b83fdc3

Copilot AI review requested due to automatic review settings October 5, 2025 09:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Restores a dedicated native packaging project (MLXSharp.Native), updates CI to use a new .slnx solution format, and refreshes documentation to reflect the reinstated native runtime layout. Key structural change is the replacement of the traditional .sln with a custom XML .slnx file referenced throughout CI.

  • Reintroduces native packaging project and updates docs to describe stub expansion behavior.
  • Replaces MLXSharp.sln with a new MLXSharp.slnx and updates CI to build/test against it.
  • Enhances CI package verification logic for native macOS library presence.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/MLXSharp.Native/runtimes/osx-arm64/native/README.txt Updated placement instruction for macOS dylib (potentially incorrect project reference).
src/MLXSharp.Native/README.md Rewritten explanation of native stub handling and packaging layout.
README.md Adjusted repository layout and package contents documentation to reflect restored native packaging approach.
MLXSharp.slnx Introduces a new non-standard XML solution file replacing the prior .sln.
MLXSharp.sln Removes the conventional Visual Studio solution file.
.github/workflows/ci.yml Points restore/build/test to .slnx and expands package validation script.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

@KSemenenko KSemenenko closed this Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants