Skip to content

Create remove_duplicates.py #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create remove_duplicates.py #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions remove_duplicates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
def give_duplicates(list):
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename list to input

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename give_duplicates to get_duplicates or find_duplicates

#create a set data structure for storing result
result = set()

#traverse through list once and record duplicates
for x in list:
x = int(x)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to typecast to int?

if int(list[abs(x)-1]) < 0:
result.add(x)
else:
list[abs(x)-1] = int(list[abs(x)-1]) - (2 * int(list[abs(x)-1]))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiply with -1 instead of subtracting. Easier to read and understand

list[abs(x)-1] = -1 * list[abs(x)-1]


return result

inp = input("Enter list of integers")
#convert string input into an array
list = inp.split()
print(give_duplicates(list))
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write few tests here using python's assert statement

Example:
assert give_duplicates([1, 1, 2]) == [1, 2]

https://www.w3schools.com/python/ref_keyword_assert.asp