Create remove_duplicates.py #153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhuri7112
commented
Jul 27, 2021
| @@ -0,0 +1,18 @@ | |||
| def give_duplicates(list): | |||
There was a problem hiding this comment.
Rename give_duplicates to get_duplicates or find_duplicates
|
|
||
| #traverse through list once and record duplicates | ||
| for x in list: | ||
| x = int(x) |
There was a problem hiding this comment.
Do you need to typecast to int?
| if int(list[abs(x)-1]) < 0: | ||
| result.add(x) | ||
| else: | ||
| list[abs(x)-1] = int(list[abs(x)-1]) - (2 * int(list[abs(x)-1])) |
There was a problem hiding this comment.
Multiply with -1 instead of subtracting. Easier to read and understand
list[abs(x)-1] = -1 * list[abs(x)-1]
| inp = input("Enter list of integers") | ||
| #convert string input into an array | ||
| list = inp.split() | ||
| print(give_duplicates(list)) |
There was a problem hiding this comment.
Write few tests here using python's assert statement
Example:
assert give_duplicates([1, 1, 2]) == [1, 2]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.