Cs 178 can open #93
Cs 178 can open #93
Conversation
…the findObjectByName function
| return getDefaultConfigDir() + "candletoolco.ini"; | ||
| } | ||
|
|
||
| inline bool fileExists(const std::string& filepath) |
There was a problem hiding this comment.
It is better to use std::filesystem::path instead of string as windows cli has a different encoding for its paths than regular strings
| } | ||
| } | ||
|
|
||
| MDCO::Error_t MDCO::writeOpenRegisters(const std::string& name, u32 data, u8 size, bool force) |
There was a problem hiding this comment.
If we want no type safety (converting anything to u32 with arbitrary size) we should at least provide helper functions with bit casts in order for the user to not be forced to do convoluted conversions themselves.
| index=0x6077 | ||
| subindex=0x00 | ||
|
|
||
| # Display torque actual value |
There was a problem hiding this comment.
The motor should also demonstrate some kind of rotation in the impedance mode example
|
|
||
| // kp | ||
| u32 kp_bits; | ||
| memcpy(&kp_bits, &(kp), sizeof(float)); |
There was a problem hiding this comment.
memcpy should not be necessary for common API tasks
examples/py/mdco_motor_detection.py
Outdated
|
|
||
| # make blink each driver led in ascending order | ||
| for i in range(len(ids)): | ||
| md = pc.MDCO(ids[i], candle); |
There was a problem hiding this comment.
semicolon at the end is invalid
| cmake_minimum_required(VERSION 3.8) | ||
|
|
||
| # Shared sources | ||
| set(COMMON_SOURCES |
There was a problem hiding this comment.
If the sources are used by examples they should be located in the candlelib as it is the main interaction point for the users an their API
| return oss.str(); | ||
| } | ||
|
|
||
| std::string toHex(u32 val, int width = 4) |
There was a problem hiding this comment.
Those function (this and the one above) should be put under mab namespace to not collide with users code. More over they are very similar, one can be used to run another which lessens the complexity or they may even be one and the same function.
Features: