[depthai_bridge] Fix incorrect include path in TFPublisher #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit corrects an erroneous include path in the TFPublisher.cpp file. The original code incorrectly repeated the 'tf2_geometry_msgs' segment in the include directive, leading to a compilation error. The updated include statement correctly references 'tf2_geometry_msgs/tf2_geometry_msgs.hpp' without repetition. This change ensures that the depthai_bridge package compiles successfully in ROS2 Humble by resolving the missing header file issue and aligns with standard ROS practices for including external dependencies. * File affected: depthai_bridge/src/TFPublisher.cpp * Issue: Compilation error due to incorrect header file path * Resolution: Correct the include path to the standard format used in ROS packages
|
@saching13 @Serafadam would appreciate your review here. Thanks! |
|
Thanks for the PR @TSC21. The CI had some problems in the past with this header so this was a temporary solution, but it seems that it has been fixed upstream 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit corrects an erroneous include path in the TFPublisher.cpp file. The original code incorrectly repeated the 'tf2_geometry_msgs' segment in the include directive, leading to a compilation error. The updated include statement correctly references 'tf2_geometry_msgs/tf2_geometry_msgs.hpp' without repetition.
This change ensures that the depthai_bridge package compiles successfully in ROS2 Humble by resolving the missing header file issue and aligns with standard ROS practices for including external dependencies.
Author: Nuno Marques (@TSC21).
Issue
depthai_bridge/src/TFPublisher.cppChanges
ROS distro: ROS 2 Humble
List of changes:
depthai_bridge/src/TFPublisher.cpp- change can be found on the diff.Testing
Hardware used: OAK-D W
Depthai library version: the one which the Humble version of this package imports.
Visuals from testing
N.A. This can be validated by buiding the package from source against an environment built from source (In this case, with the srcs generated using
rosinstall_generatorand usingvcs import). Fixing this include allowed to builddepthai_bridgefrom source.