Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSIM-1189: Remove unused attributes from Conditions object #100

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Sep 12, 2024

Remove unused attributes from Conditions object.

@yoachim yoachim force-pushed the tickets/OPSIM-1189 branch 4 times, most recently from ab73565 to 7493754 Compare September 12, 2024 21:01
@rhiannonlynne
Copy link
Member

Oh wow, I really thought something was using the seasons information in the conditions object -- however, I looked at all of the features which I thought were using it and no .. they hold it internally. Maybe it was at some intermediate point of development? Maybe some of the footprint basis functions did at some point? Anyway, it's good to clear it out. I'm pretty sure nothing in ts_fbs_utils uses these, but if you could double-check that would be helpful. (I don't actually know if we would see any failures, unless you also try to run the schedulers it creates though).

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@@ -572,7 +520,7 @@ def az_to_antisun(self):
return self._az_to_antisun

def __repr__(self):
return f"<{self.__class__.__name__} mjd_start='{self.mjd_start}' at {hex(id(self))}>"
return f"<{self.__class__.__name__} at {hex(id(self))}>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to have this print the current time (not sure why it was mjd_start before, but conditions.mjd might be a good shortcut).

@yoachim yoachim merged commit 114b83f into main Sep 13, 2024
7 checks passed
@rhiannonlynne rhiannonlynne changed the title remove extras from Conditions object OPSIM-1189: Remove unused attributes from Conditions object Sep 14, 2024
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1189 branch September 16, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants