OPSIM-1190: remove deprecated features and basis functions

[rhiannonlynne]

Removed basis functions: LimitObsPnightBasisFunction SunHighLimitBasisFunction TargetMapBasisFunction AvoidLongGapsBasisFunction AvoidFastRevisits GoalStrictFilterBasisFunction AggressiveSlewtimeBasisFunction SkybrightnessLimitAtHpixBasisFunction SkybrightnessLimitBasisFunction CablewrapUnwrapBasisFunction TemplateGenerateBasisFunction FootprintNvisBasisFunction ThirdObservationBasisFunction NearSunTwilightBasisFunction ObservedTwiceBasisFunction LimitRepeatBasisFunction ZenithShadowMaskBasisFunction MaskAzimuthBasisFunction TargetMapModuloBasisFunction

Removed features: NObsSurvey (and note that NObsCount now accepts a note as well as a filter name to double for what was previously in NObsSurvey), LastsequenceObservation LastFilterChange CoaddedDepth NObservationsSeason NObsCountSeason SurveyInNight

Simplified use of ad-hoc surveys in unit tests by swapping in simple_pairs_survey and simple_greedy_survey. Unit test coverage remains the ~same (slightly higher).

Caught a bug in a (now used in unit test) sunAltBasisFunction.

[rhiannonlynne]

Tagging @tribeiro on this PR in particular .. I know you're looking at what we're changing, and so probably also noticed #102 in particular (for the change from empty_observation -> ObservationsArray), as well as #100 (conditions object update, probably just pulling out things you weren't adding anyway) and #88 for the updates to the AltAzShadowMaskBasisFunction + use with conditions.tel_alt_limits, conditions.tel_az_limits, and conditions.kinematic_alt_limits, conditions.kinematic_az_limits.

[rhiannonlynne]

For clarity - I would like to request the review from @yoachim .. Tiago says he's ok with that :)

[yoachim]

Looks good. ZenithShadowMaskBasisFunction is still being used in ts_fbs_utils. Could just make that a subclass of AltAzShadowMaskBasisFunction and it'll probably work.

The SunAltLimitBasisFunction is only being used in tests. But it's small enough that it's fine if it survives the purge.

I was surprised RotatorAngle made the cut, but does seem like it's getting used.

[rhiannonlynne]

I really only deprecated the things which had been marked earlier, or which once those things had been removed, no longer worked - so I might have missed some. I may have taken a few more things if they didn't have all the class attributes, but figured these were things I'd just failed to mark earlier.

I'm going to go ahead and remove the ZenithMaskShadowFunction and do a pr for ts-FBs-utils ... I think it will need more work anyway (I thought it was using the TargetMapBasis function, though could be wrong).