-
Notifications
You must be signed in to change notification settings - Fork 17
DM-53233: Add resource cleanup interface to Butler #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dhirving
wants to merge
13
commits into
main
Choose a base branch
from
tickets/DM-53233
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+991
−718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c47ff55 to
015b09c
Compare
Remove a type hint for `DirectButler.datastore`, which is never actually assigned or used. The actual object is `_datastore`.
Add a close() method and a context manager implementation to Butler, to prevent resource leaks. This allows users to ensure that database connections are closed promptly.
015b09c to
b4490d5
Compare
Ensure that close() is called on all Butler instances created during unit tests, to ensure that file handles associated with database connections are closed promptly. This fixes an issue where tests could fail due to file descriptor exhaustion.
Eliminate circular references from Butler instances so that it gets garbage collected immediately when it goes out of scope.
b4490d5 to
71b0479
Compare
Add a close() method to allow cleanup of QuantumBackedButler's internal sqlite instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a close() method and a context manager implementation to Butler, to prevent resource leaks. This allows users to ensure that database connections are closed promptly.
Checklist
doc/changesconfigs/old_dimensions