Skip to content

Commit c47ff55

Browse files
committed
Fix resource leaks from get_dataset_from_uri
1 parent 89c61bb commit c47ff55

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tests/test_simpleButler.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -942,13 +942,15 @@ def test_dataset_uris(self):
942942
f"ivo://org.rubinobs/usdac/lsst-dp1?repo={label}&id={ref.id}",
943943
):
944944
result = Butler.get_dataset_from_uri(dataset_uri)
945+
self.enterContext(result.butler)
945946
self.assertEqual(result.dataset, ref)
946947
# The returned butler needs to have the datastore mocked.
947948
DatastoreMock.apply(result.butler)
948949
dataset_id, _ = result.butler.get(result.dataset)
949950
self.assertEqual(dataset_id, ref.id)
950951

951952
factory_result = Butler.get_dataset_from_uri(dataset_uri, factory=factory)
953+
self.enterContext(factory_result.butler)
952954
self.assertEqual(factory_result.dataset, ref)
953955
# The returned butler needs to have the datastore mocked.
954956
DatastoreMock.apply(factory_result.butler)
@@ -958,6 +960,7 @@ def test_dataset_uris(self):
958960
# Non existent dataset.
959961
missing_id = str(ref.id).replace("2", "3")
960962
result = Butler.get_dataset_from_uri(f"butler://{label}/{missing_id}")
963+
self.enterContext(result.butler)
961964
self.assertIsNone(result.dataset)
962965

963966
# Test some failure modes.

0 commit comments

Comments
 (0)