Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new custom option for color config, marked themes folder as deprecated. #851

Merged
merged 5 commits into from
Jun 23, 2023

Conversation

peppidesu
Copy link
Contributor

@peppidesu peppidesu commented May 28, 2023

#749: when color: custom is specified, lsd will look for $XDG/lsd/colors.yaml and load the theme. The old custom theme behaviour is marked as deprecated and will show a warning when used.

  • Renamed ThemeOption::Custom to ThemeOption::CustomLegacy
  • Added new ThemeOption::Custom

TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@muniu-bot
Copy link

muniu-bot bot commented May 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: peppidesu

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #851 (fd28652) into master (2fe3fcd) will decrease coverage by 0.02%.
The diff coverage is 76.47%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
- Coverage   86.48%   86.46%   -0.02%     
==========================================
  Files          49       49              
  Lines        4602     4610       +8     
==========================================
+ Hits         3980     3986       +6     
- Misses        622      624       +2     
Impacted Files Coverage Δ
src/flags/color.rs 92.24% <50.00%> (-0.81%) ⬇️
src/color.rs 50.80% <84.61%> (+1.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

README.md Show resolved Hide resolved
@zwpaper zwpaper mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants