Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .bak (backup) files have a regular file icon #910

Closed
wants to merge 1 commit into from

Conversation

alichtman
Copy link
Contributor

@alichtman alichtman commented Sep 24, 2023

I think the right icon for these types of files is the icon for
the filename without the ".bak" suffix.

But, this should be a quick improvement to the current implementation

 session_migration-ubuntu
 session_migration-ubuntu-wayland
 user-places.xbel
󰁯 user-places.xbel.bak
 user-places.xbel.tbcache

I think the right icon for these types of files is the icon for
the filename without the ".bak" suffix.

But, this should be a quick improvement to the current implementation

```
 session_migration-ubuntu
 session_migration-ubuntu-wayland
 user-places.xbel
󰁯 user-places.xbel.bak
 user-places.xbel.tbcache
```
@muniu-bot muniu-bot bot added the size/XS label Sep 24, 2023
@alichtman alichtman changed the title master Make .bak (backup) files have a regular file icon Sep 24, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #910 (df53719) into master (949128f) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #910   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files          51       51           
  Lines        5005     5005           
=======================================
  Hits         4292     4292           
  Misses        713      713           
Files Changed Coverage Δ
src/theme/icon.rs 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zwpaper
Copy link
Member

zwpaper commented Sep 28, 2023

hi @alichtman, thanks for contributing, but it seems reasonable that the bak file uses an icon to indicate that.

If you prefer to change it, you could try the icon theme.

@zwpaper zwpaper closed this Sep 28, 2023
@alichtman
Copy link
Contributor Author

alichtman commented Sep 28, 2023

@zwpaper Right. I think you misunderstood my commit (since it does exactly what you suggest it should have done).

The file icon lsd uses for bak is currently unprintable with ligature fonts.

This commit makes it the generic file icon (which is printable).

Please take another look at the commit. Note that the commit summary will not render properly on GitHub mobile, due to a lack of ligature support.

@zwpaper
Copy link
Member

zwpaper commented Sep 29, 2023

Hi @alichtman, bak works as expected here, it would be related to the font you using, as I said, you could change it in the icon theme or pick a font with the icon:

image

@alichtman
Copy link
Contributor Author

alichtman commented Sep 29, 2023

Huh, looks like the problem is on my end. Thanks for the response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants