Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI adjustments to align with iOS; exercise and lecture list item redesign #43

Merged
merged 7 commits into from
Oct 23, 2024
Merged

UI adjustments to align with iOS; exercise and lecture list item redesign #43

merged 7 commits into from
Oct 23, 2024

Conversation

julian-wls
Copy link
Contributor

@julian-wls julian-wls commented Oct 3, 2024 •
edited
Loading

Some small design changes before the 1st release:

Screenshots

Exercise list item:
course4

Lecture list item:
lecture

@julian-wls julian-wls self-assigned this Oct 3, 2024
@TimOrtel
Copy link
Contributor

TimOrtel commented Oct 4, 2024

In general, please give the PRs more descriptive names. For example: UI adjustments to align with iOS

@julian-wls julian-wls mentioned this pull request Oct 6, 2024
Open
TimOrtel
TimOrtel approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@TimOrtel TimOrtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now.

asliayk
asliayk approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@asliayk asliayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@julian-wls julian-wls changed the title UI and UX improvements UI adjustments to align with iOS; exercise and lecture list item redesign Oct 17, 2024
@FelberMartin FelberMartin self-requested a review October 18, 2024 20:12
FelberMartin
FelberMartin requested changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out the changes and I highly appreciate the UI adjustments, looks so much better now!

I just have a few adjustments regarding the padding of the items to make it more consistent.

However I am not sure whether it is okay to just push these changes to the branch or should I rather add the changes as comments? Please let me know!

@julian-wls
Copy link
Contributor Author

I checked out the changes and I highly appreciate the UI adjustments, looks so much better now!

I just have a few adjustments regarding the padding of the items to make it more consistent.

However I am not sure whether it is okay to just push these changes to the branch or should I rather add the changes as comments? Please let me know!

Thank you :) Please feel free to push the changes you have in mind!

FelberMartin
FelberMartin approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adapted padding so that there is a consistent padding of 16dp on the exercise and lecture ListItems

@FelberMartin FelberMartin merged commit d8a8980 into main Oct 23, 2024
2 of 3 checks passed
@FelberMartin FelberMartin deleted the general/ui_and_ux_improvements branch October 23, 2024 16:06
@FelberMartin FelberMartin mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimOrtel TimOrtel TimOrtel approved these changes

@asliayk asliayk asliayk approved these changes

@FelberMartin FelberMartin FelberMartin approved these changes

Assignees

@julian-wls julian-wls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julian-wls @TimOrtel @FelberMartin @asliayk