Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Enabling EdgeToEdge #68

Closed
FelberMartin opened this issue Oct 23, 2024 · 1 comment · Fixed by #91
Closed

Re-Enabling EdgeToEdge #68

FelberMartin opened this issue Oct 23, 2024 · 1 comment · Fixed by #91
Assignees
Labels
improvement Minor improvements, no new functionality

Comments

@FelberMartin
Copy link
Collaborator

I found that with enableEdgeToEdge() introduced in #43 the keyboard was covering the message TextField in the Chat UI (see screenshot below).
image

The same also holds for other TextFields. Eg when tapping on the Search in the ConversationOverview, the Keyboard covers the FAB-Button (for creating new chats). Without the enableEdgeToEdge() this does not happen.

Therefore I temporally removed this line from main.

Next Steps

  • Confirm whether this is not just an issue on the emulator but also on the physical device.
  • Resolve the issue. I found that by adding Modifer.imePadding() eg to line 320 of CourseUiScreen.kt does remove the problem. However, I am not sure what the best approach is to fix this consistently. There are probably much more TextFields that cause the same problem and adding the Modifier to each and every Scaffold does not feel right imo
@julian-wls
Copy link
Contributor

I think we need to use insets to handle any overlapping as described here. I think using Modifier.imePadding() is the correct way even though it feels a bit weird, but the documentation handles it that way. I'll take a deeper look in the next days.

@julian-wls julian-wls self-assigned this Oct 24, 2024
@FelberMartin FelberMartin added the improvement Minor improvements, no new functionality label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Minor improvements, no new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants