Skip to content

Commit

Permalink
feat(argus): changes done for releasing argus v8.0.0 (#121)
Browse files Browse the repository at this point in the history
* feat(argus): changes done for releasing argus v8.0.0

changes done for releasing argus v8.0.0

* fix(argus): fixed appVersion

fixed appVersion

---------

Co-authored-by: Gurusiddha Kore <[email protected]>
  • Loading branch information
gurusiddha and guru13-lm authored Nov 21, 2023
1 parent fcacc6e commit ff9e7b7
Show file tree
Hide file tree
Showing 6 changed files with 78 additions and 3 deletions.
4 changes: 2 additions & 2 deletions charts/argus/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ maintainers:
- email: [email protected]
name: LogicMonitor
name: argus
version: 7.0.0
version: 8.0.0
home: https://logicmonitor.github.io/helm-charts
appVersion: v11.4.0
appVersion: v12.0.0
dependencies:
- name: lmutil
repository: https://logicmonitor.github.io/helm-charts
Expand Down
2 changes: 2 additions & 0 deletions charts/argus/templates/_argus_config.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ log:
etcdDiscoveryToken: {{ .Values.etcdDiscoveryToken | quote }}
clusterTreeParentID: {{ .Values.clusterTreeParentID }}
resourceContainerID: {{ .Values.resourceContainerID }}
overview:
{{- toYaml .Values.overview | nindent 2 }}
enableLegacyResourceTree: {{ .Values.enableLegacyResourceTree }}
globalDeleteAfterDuration: {{ .Values.lm.resource.globalDeleteAfterDuration | default "P0DT0H0M0S" }}
{{- if .Values.telemetryCronString }}
Expand Down
27 changes: 27 additions & 0 deletions charts/argus/templates/_collector.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -99,3 +99,30 @@ capabilities:
{{- end }}
{{- end }}
{{- end }}

{{/* This template is used for validating COLLECTOR_NON_ROOT env variable, please do not print anything here */}}
{{- define "non-root-prop-check"}}
{{$isKeyInvalid := false}}
{{$isValueInvalid := false}}
{{- $trueCheckList := list "true" "1" "True" "yes" "Yes"}}
{{- $falseCheckList := list "false" "0" "False" "no" "No"}}
{{- if not (empty .Values.collector.env)}}
{{- range $key, $value := .Values.collector.env }}
{{- if eq (upper $key) "COLLECTOR_NON_ROOT"}}
{{- if eq $key "COLLECTOR_NON_ROOT"}}
{{- if and (not (empty $value)) (not (or (has $value $falseCheckList) (has $value $trueCheckList))) }}
{{- $isValueInvalid = true}}
{{- end}}
{{- else }}
{{- $isKeyInvalid = true}}
{{- end }}
{{- end}}
{{- end}}
{{- if $isKeyInvalid }}
{{- fail (printf "COLLECTOR_NON_ROOT param is case sensitive, please check your configurations.") }}
{{- end}}
{{- if $isValueInvalid }}
{{- fail (printf "Please provide a valid boolean value for COLLECTOR_NON_ROOT param")}}
{{- end}}
{{- end}}
{{- end}}
1 change: 1 addition & 0 deletions charts/argus/templates/collectorset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ spec:
{{- end }}
{{- if .Values.collector.env }}
env:
{{- include "non-root-prop-check" . | nindent 4 }}
{{- toYaml .Values.collector.env | nindent 4 }}
{{- end }}

Expand Down
41 changes: 41 additions & 0 deletions charts/argus/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1314,6 +1314,47 @@
},
"uniqueItems": true
},
"overview": {
"$id": "#/properties/overview",
"$comment": "tf:optional",
"type": "object",
"title": "The Overview schema",
"description": "Configurations for Overview Dashboard.",
"default": {},
"examples": [
{
"enable": false,
"duration": "* * * * *"
}
],
"required": [
],
"properties": {
"enable": {
"$comment": "tf:optional",
"$id": "#/properties/overview/properties/enable",
"type": "boolean",
"title": "The enable schema",
"description": "Once the property is enabled, argus pod annotation will be updated after every duration interval. ",
"default": false,
"examples": [
false,
true
]
},
"duration": {
"$comment": "tf:optional",
"$id": "#/properties/overview/properties/duration",
"type": "string",
"title": "The duration schema",
"description": "Duration of argus pod annotation update in cron.",
"examples": [
"* * * * *"
]
}
},
"additionalProperties": false
},
"selfMonitor": {
"$id": "#/properties/selfMonitor",
"$comment": "tf:optional",
Expand Down
6 changes: 5 additions & 1 deletion charts/argus/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ collector:
# The number of collectors to create and use with Argus.
replicas: 1
version: 0
size: "small"
size: "medium"
useEA: false
# The collector size to install. Can be nano, small, medium, or large.
lm:
Expand Down Expand Up @@ -203,6 +203,10 @@ securityContext:
add: []
drop: []

overview:
enable: false
duration: "* * * * *"

global:
accessID: ""
accessKey: ""
Expand Down

0 comments on commit ff9e7b7

Please sign in to comment.