Update lnurl.py #17
Closed
Update lnurl.py #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent double spend by checking, if payload is already in DB. If yes, then it's not adding new line into the DB with same payload. In case of failed transaction is returned payhash value to "payment_hash" so user can try the QR code again with different wallet.
This was referenced Aug 6, 2023
dni
approved these changes
Aug 7, 2023
|
You cant currently double spend, so it does not require a fix |
#15 check this issue, the fix was required |
Merysol
approved these changes
Oct 10, 2023
|
can you resolve the conflicts? |
|
Fixed this issue another way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent double spend by checking, if payload is already in DB. If yes, then it's not adding new line into the DB with same payload.
In case of failed transaction is returned payhash value to "payment_hash" so user can try the QR code again with different wallet.