Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to scan ATMs second time (after failed payment) #16

Open
webiumsk opened this issue Aug 3, 2023 · 3 comments
Open

Unable to scan ATMs second time (after failed payment) #16

webiumsk opened this issue Aug 3, 2023 · 3 comments

Comments

@webiumsk
Copy link

webiumsk commented Aug 3, 2023

Reproduce:
Put some fiat in your ATM.
Use a wallet with insufficient incoming capacity (just to make sure such amount can't go through and the payment will fail)
Obviously, you will get "Payment failed, use a different wallet."

But with different wallet you will get message "Payment already claimed".
And there is no evidence of this failed payment in LNBits wallet

Expected behavior:
Don't mark the payment as paid, until it's really paid.
There should be a record for waiting, not fulfilled payment in LNbits wallet

LNbits 0.9.10
lnurldevice 0.5.5

@supiiik
Copy link
Contributor

supiiik commented Aug 6, 2023

#17

@cos-it-is
Copy link

I have added a workaround in my atm for this which does a balance check after each Withdrawl.

It gets the wallet balance from the API, then checks against the max amount for the atm.

@webiumsk
Copy link
Author

I have added a workaround in my atm for this which does a balance check after each Withdrawl.

It gets the wallet balance from the API, then checks against the max amount for the atm.

The problem here is not with insufficient balance on server, but with incoming liquidity in users wallet and failed withdraw.
But @supiiik 's solution works pretty well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants