Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create asset summaries #157

Merged
merged 18 commits into from
Nov 24, 2021
Merged

feat: Create asset summaries #157

merged 18 commits into from
Nov 24, 2021

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Nov 14, 2021

No description provided.

@l0b0 l0b0 requested review from imincik, blacha, dwsilk, MitchellPaff and billgeo and removed request for imincik November 14, 2021 23:19
MitchellPaff
MitchellPaff previously approved these changes Nov 15, 2021
View reviewed changes
@billgeo
Copy link
Contributor

billgeo commented Nov 15, 2021

LGTM. But @m-mohr has offered to discuss how to approach this at the next STAC meeting. So maybe we can leave this in draft until after then?

@l0b0 l0b0 marked this pull request as draft November 15, 2021 00:41
@l0b0 l0b0 mentioned this pull request Nov 21, 2021
Closed
4 tasks
@l0b0
Copy link
Contributor Author

l0b0 commented Nov 22, 2021

LGTM. But @m-mohr has offered to discuss how to approach this at the next STAC meeting. So maybe we can leave this in draft until after then?

When is the meeting?

@billgeo
Copy link
Contributor

billgeo commented Nov 23, 2021

See radiantearth/stac-spec#1153 (comment)

Will have to keep this open for another week.

@dwsilk
Copy link
Member

dwsilk commented Nov 23, 2021

Or can we merge and adjust to suit later? I prefer to implement the outcome of this PR than how it currently is, and we are working on this now.

@billgeo
Copy link
Contributor

billgeo commented Nov 23, 2021

I'm okay with that, with the proviso that we might change this later based on feedback from the STAC community.

l0b0 added 15 commits November 23, 2021 15:27
@l0b0
feat: Require 'linz:asset_summaries' root property
ddcba71
@l0b0
feat: Require asset summary 'created' propert
9931751
@l0b0
feat: require asset summary created 'minimum' property
ed32691
@l0b0
feat: require asset summary created minimum property be a string
ab4bf48
@l0b0
feat: require asset summary created minimum property be a datetime
208c890
@l0b0
feat: require asset summary created minimum property be a UTC datetime
96f29c0
@l0b0
refactor: Pull out UTC datetime definition
9a5669d
@l0b0
docs: Set asset/metadata summary created/updated titles
084f8dd
@l0b0
feat: require asset summary created 'maximum' property
7d81ff5
@l0b0
feat: require asset summary created maximum property be a UTC datetime
f401fad
@l0b0
feat: require asset summary 'updated' property
abc190f
@l0b0
feat: require asset summary updated 'minimum' property
29d00d2
@l0b0
feat: require asset summary updated minimum property be a UTC datetime
2662008
@l0b0
feat: require asset summary updated 'maximum' property
16b2487
@l0b0
feat: require asset summary updated maximum property be a UTC datetime
97325bc
@l0b0 l0b0 force-pushed the feat/create-asset-summaries branch from 1a73dba to 97325bc Compare November 23, 2021 02:53
@l0b0 l0b0 marked this pull request as ready for review November 23, 2021 02:53
@l0b0 l0b0 requested a review from MitchellPaff November 23, 2021 02:53
billgeo
billgeo suggested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@billgeo billgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some README docs about this new metadata

@l0b0 l0b0 requested a review from billgeo November 23, 2021 22:49
@l0b0 l0b0 mentioned this pull request Nov 23, 2021
Merged
@l0b0 l0b0 added the automerge kodiak automerge label label Nov 23, 2021
@kodiakhq kodiakhq bot merged commit 497c182 into master Nov 24, 2021
@kodiakhq kodiakhq bot deleted the feat/create-asset-summaries branch November 24, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amfage amfage amfage approved these changes

@billgeo billgeo billgeo approved these changes

@blacha blacha Awaiting requested review from blacha

@dwsilk dwsilk Awaiting requested review from dwsilk

@MitchellPaff MitchellPaff Awaiting requested review from MitchellPaff

Assignees
No one assigned
Labels
automerge kodiak automerge label
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@l0b0 @billgeo @dwsilk @amfage @MitchellPaff