Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Summaries of asset created and updated datetimes breaks the stac spec #143

Closed
3 of 4 tasks
billgeo opened this issue Nov 2, 2021 · 2 comments
Closed
3 of 4 tasks
Assignees
Labels
bug Something isn't working

Comments

@billgeo
Copy link
Contributor

billgeo commented Nov 2, 2021

[Please remove this and other [placeholder text] before submitting.]

Describe the bug
Currently the summaries we have specified look like this:

"summaries": {
"created": {
"minimum": "1999-01-01T00:00:00Z",
"maximum": "2010-01-01T00:00:00Z"
},
"updated": {
"minimum": "1999-01-02T00:00:00Z",
"maximum": "2010-01-02T00:00:00Z"
},
"datetime": {
"minimum": "2015-06-23T00:00:00Z",
"maximum": "2019-07-10T13:44:56Z"
},

This is what the summary of the item created updated datetimes look like (when the metadata is updated, not the asset).

See discussion here. radiantearth/stac-spec#1153 and radiantearth/stac-spec#1156

Could look like this:

   "summaries": {
      "created": {
        "minimum": "1901-01-01T00:00:00Z",
        "maximum": "1920-01-01T00:00:00Z"
      },
      "updated": {
        "minimum": "1901-01-02T00:00:00Z",
        "maximum": "1920-01-02T00:00:00Z"
      }
  }

And the the summary with other properties would look something like this.

   "summaries": {
    "assets": {
      "created": {
        "minimum": "1901-01-01T00:00:00Z",
        "maximum": "1920-01-01T00:00:00Z"
      },
      "updated": {
        "minimum": "1901-01-02T00:00:00Z",
        "maximum": "1920-01-02T00:00:00Z"
      }
    },
    "platform": ["Fixed-wing Aircraft"],
    "instruments": ["EAGLE IV"],
    "created": {
      "minimum": "1999-01-01T00:00:00Z",
      "maximum": "2010-01-01T00:00:00Z"
    },
    "updated": {
      "minimum": "1999-01-02T00:00:00Z",
      "maximum": "2010-01-02T00:00:00Z"
    } 
  },

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
[A clear and concise description of what you expected to happen.]

Actual behavior
[Describe what actually happened.]

[If applicable, add logs to help explain your problem:]

[Paste logs here]

Additional context
[Add any other context about the problem here.]

Tasks

  • Check if summaries can be extended or not
  • If we can, create new summary properties that relate only to assets and make mandatory
  • If we can't, discuss alternatives to capturing this metadata somewhere and make mandatory
  • Remove mandatory schema check for summaries having an 'updatedandcreated` datetimes [Bill confirmed this is only mandatory for published data so the mandatory schema check can be removed]
@l0b0
Copy link
Contributor

l0b0 commented Nov 21, 2021

Blocked by #157 (comment).

@billgeo
Copy link
Contributor Author

billgeo commented Nov 24, 2021

This is done now. Will open a new issue if there are changes/recommendations from upstream.

@billgeo billgeo closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants